Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_period_id() with dayPeriodRule across 0:00 #871

Merged
merged 1 commit into from
May 10, 2022

Conversation

jun66j5
Copy link
Contributor

@jun66j5 jun66j5 commented May 1, 2022

Fix for #870.

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #871 (17d1af9) into master (3ae5402) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   91.34%   91.32%   -0.02%     
==========================================
  Files          23       23              
  Lines        4192     4198       +6     
==========================================
+ Hits         3829     3834       +5     
- Misses        363      364       +1     
Impacted Files Coverage Δ
babel/dates.py 92.47% <100.00%> (-0.08%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akx akx self-requested a review May 10, 2022 06:48
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! I would have added a comment noting that the first if statement takes care of rules that straddle days, but it's evident from the commit message. 😄

@akx akx merged commit 128322c into python-babel:master May 10, 2022
@akx akx added this to the Babel 2.10.2 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants