Skip byte strings in extract_python instead of crashing#1259
Open
bysiber wants to merge 1 commit intopython-babel:masterfrom
Open
Skip byte strings in extract_python instead of crashing#1259bysiber wants to merge 1 commit intopython-babel:masterfrom
bysiber wants to merge 1 commit intopython-babel:masterfrom
Conversation
When a byte string like _(b'foo') is encountered during message extraction, _parse_python_string would return the bytes object which then caused a TypeError in ''.join(buf). Byte strings are not valid translation strings anyway, so return None to skip them. Added a test to confirm byte strings are silently skipped while normal strings are still extracted correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
pybabel extractencounters a byte string like_(b'foo'),_parse_python_stringreturns abytesobject which then causes''.join(buf)to crash withTypeError: sequence item 0: expected str instance, bytes found.Since byte strings are not valid translation strings (gettext uses normal strings internally), this just skips them by returning
Nonefrom_parse_python_stringwhen it encounters bytes.Added a test that confirms byte strings are silently skipped while normal strings in the same file are still extracted correctly.
Fixes #1190