Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deleted duplicate code in test" #1138

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

mattdiaz007
Copy link
Contributor

@mattdiaz007 mattdiaz007 commented Oct 4, 2024

Line 55 in test_numbers.py appeared to be a duplicate of the line before it

Fixes #1025.

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks :)

@akx akx enabled auto-merge (squash) October 19, 2024 12:16
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (f91754b) to head (e248972).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          27       27           
  Lines        4602     4602           
=======================================
  Hits         4200     4200           
  Misses        402      402           
Flag Coverage Δ
macos-12-3.10 90.06% <ø> (ø)
macos-12-3.11 90.00% <ø> (ø)
macos-12-3.12 90.17% <ø> (ø)
macos-12-3.13-dev 89.70% <ø> (ø)
macos-12-3.8 89.99% <ø> (ø)
macos-12-3.9 89.99% <ø> (ø)
macos-12-pypy3.10 90.06% <ø> (ø)
ubuntu-22.04-3.10 90.09% <ø> (ø)
ubuntu-22.04-3.11 90.02% <ø> (ø)
ubuntu-22.04-3.12 90.19% <ø> (ø)
ubuntu-22.04-3.13-dev 89.72% <ø> (ø)
ubuntu-22.04-3.8 90.01% <ø> (ø)
ubuntu-22.04-3.9 90.01% <ø> (ø)
ubuntu-22.04-pypy3.10 90.09% <ø> (ø)
windows-2022-3.10 90.21% <ø> (ø)
windows-2022-3.11 90.14% <ø> (ø)
windows-2022-3.12 90.31% <ø> (ø)
windows-2022-3.13-dev 89.84% <ø> (ø)
windows-2022-3.8 90.13% <ø> (ø)
windows-2022-3.9 90.13% <ø> (ø)
windows-2022-pypy3.10 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx merged commit b246a5f into python-babel:master Oct 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate test case for number format?
3 participants