Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-import AttrsInstance in attrs ns #994

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Re-import AttrsInstance in attrs ns #994

merged 1 commit into from
Aug 7, 2022

Conversation

hynek
Copy link
Member

@hynek hynek commented Aug 6, 2022

@hynek hynek requested a review from Tinche August 6, 2022 07:44
@hynek hynek enabled auto-merge (squash) August 6, 2022 07:44
@hynek hynek merged commit 983c2c4 into main Aug 7, 2022
@hynek hynek deleted the re-import-attrsinstance branch August 7, 2022 00:13
@Tinche
Copy link
Member

Tinche commented Aug 7, 2022

I need to fix that Mypy caching bug for the magic attribute, don't I?

@hynek
Copy link
Member Author

hynek commented Aug 7, 2022

If you want it fixed… 😇

@Tinche
Copy link
Member

Tinche commented Aug 7, 2022

If I don't fix it, mypy won't recognize the magic attribute and the protocol will be useless. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinche Tinche Tinche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynek @Tinche