Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor class creation #272

Merged
merged 25 commits into from
Oct 26, 2017
Merged

Refactor class creation #272

merged 25 commits into from
Oct 26, 2017

Commits on Oct 6, 2017

  1. Add replace_class argument to attr.s 

    This allows us to harmonize class creation for dict and slots classes.

Ref #223 #202
    @hynek
    hynek committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    ca83971 View commit details
    Browse the repository at this point in the history

  2. Use replaced classes in testing strategy

    @hynek
    hynek committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    9ea23f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Fix replace_class always generating slot classes.

    @Tinche
    Tinche committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    33d61bc View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2017

  1. Polish changelog

    @hynek
    hynek committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    84a89fb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Always replace, add a compat shim for hashing by object ID

    @hynek
    hynek committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    f7a4c61 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2017

  1. Better changelog wording

    @hynek
    hynek committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    645dee7 View commit details
    Browse the repository at this point in the history

  2. Uncomment assert

    @hynek
    hynek committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    56bc177 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. Merge branch 'master' into replace-class

    @wsanchez
    wsanchez authored Oct 16, 2017
    Configuration menu
    Copy the full SHA
    ac432b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Leave super_attrs a tuple 

    They may contain a unhashable default.
    @hynek
    hynek committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    6dd4b1d View commit details
    Browse the repository at this point in the history

  2. Fix how-does-it-work to new approach

    @hynek
    hynek committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    628770c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. Add comment, add regression test 

    The test fails if we try to do a `hash is False and slots is True`.
    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    cff9557 View commit details
    Browse the repository at this point in the history

  2. Clarify by looping

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    11e38bb View commit details
    Browse the repository at this point in the history

  3. Fix super class attribute overwriting

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    507d9d5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into replace-class

    @hynek
    hynek authored Oct 19, 2017
    Configuration menu
    Copy the full SHA
    44c7ade View commit details
    Browse the repository at this point in the history

  5. Fix cell rewriting some more. (#270)

    @Tinche @hynek
    Tinche authored and hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    69740a0 View commit details
    Browse the repository at this point in the history

  6. Add end-to-end test for effects of cells and __init_subclass__

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    09c94b4 View commit details
    Browse the repository at this point in the history

  7. Revert functional changes and make it a sole refactoring

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    ba077e5 View commit details
    Browse the repository at this point in the history

  8. Simplify, better naming

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    f076876 View commit details
    Browse the repository at this point in the history

  9. Add news fragment

    @hynek
    hynek committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    b5360af View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2017

  1. Simplify 

    The counting_attrs field hasn't been used anywhere.
    @hynek
    hynek committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    63c99c8 View commit details
    Browse the repository at this point in the history

  2. More comments

    @hynek
    hynek committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    3b2921e View commit details
    Browse the repository at this point in the history

  3. Update slots caveats

    @hynek
    hynek committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    db47fb2 View commit details
    Browse the repository at this point in the history

  4. Include Getting help in main doc page

    @hynek
    hynek committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    f2d4b03 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Simplify 

    Saves a bunch of unneeded conversions
    @hynek
    hynek committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    ea4eb5a View commit details
    Browse the repository at this point in the history

  2. Fix new flake8 failure

    @hynek
    hynek committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    8663bd1 View commit details
    Browse the repository at this point in the history