Fix AsyncRunner failure on Python 3.14 due to asyncio.get_event_loop() removal #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) removal In Python 3.14, asyncio.get_event_loop() raises RuntimeError when no event loop is running. Replace with a version-agnostic approach that: 1. Tries asyncio.get_running_loop() first 2. Falls back to creating a new event loop if none exists This works on Python 3.7+ and handles all cases correctly. Fixes #489
basnijholt
force-pushed
the
fix-python314-asyncio-get-event-loop
branch
from
d94be19 to
cfc886b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AsyncRunnerinstantiation failure on Python 3.14 whereasyncio.get_event_loop()raisesRuntimeErrorwhen no event loop is running_get_or_create_event_loop()helper that usesget_running_loop()with fallback tonew_event_loop()Test plan
Fixes #489