Skip to content

Type hint IntegratorLearner #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Type hint IntegratorLearner #372

merged 3 commits into from
Oct 12, 2022

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@codecov-commenter
Copy link

Codecov Report

Merging #372 (ae70ec8) into main (1b7e84d) will decrease coverage by 0.04%.
The diff coverage is 91.78%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   77.67%   77.63%   -0.05%     
==========================================
  Files          37       37              
  Lines        5393     5401       +8     
  Branches      981      982       +1     
==========================================
+ Hits         4189     4193       +4     
- Misses       1058     1062       +4     
  Partials      146      146              
Impacted Files Coverage Δ
adaptive/learner/integrator_learner.py 87.35% <87.50%> (-1.27%) ⬇️
adaptive/tests/algorithm_4.py 71.26% <96.29%> (+0.08%) ⬆️
adaptive/learner/integrator_coeffs.py 95.74% <100.00%> (+0.04%) ⬆️
adaptive/learner/average_learner1D.py 74.00% <0.00%> (-0.67%) ⬇️
adaptive/learner/learner1D.py 87.16% <0.00%> (-0.50%) ⬇️
adaptive/learner/learnerND.py 59.10% <0.00%> (+0.37%) ⬆️
adaptive/tests/test_cquad.py 92.25% <0.00%> (+0.64%) ⬆️
adaptive/runner.py 69.28% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt merged commit 00e66ea into main Oct 12, 2022
@basnijholt basnijholt deleted the type-hint-integrator_learner branch October 12, 2022 04:59
@basnijholt basnijholt mentioned this pull request Oct 12, 2022
basnijholt added a commit that referenced this pull request Apr 7, 2023
* Add type-hints to adaptive/learner/integrator_learner.py

* Add type-hints to adaptive/tests/algorithm_4.py

* Add type-hints to adaptive/learner/integrator_coeffs.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants