Skip to content

Optionally run tests with pandas #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Optionally run tests with pandas #369

merged 6 commits into from
Oct 11, 2022

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Oct 11, 2022

Description

This ensures that the minimal dependencies test runs correctly.
Right now pandas is always installed.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@codecov-commenter
Copy link

Codecov Report

Merging #369 (290f744) into master (50fae43) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 290f744 differs from pull request most recent head 14e6ad8. Consider uploading reports for the commit 14e6ad8 to get more accurate results

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   80.33%   80.24%   -0.09%     
==========================================
  Files          37       37              
  Lines        5375     5377       +2     
  Branches      979      979              
==========================================
- Hits         4318     4315       -3     
- Misses        890      892       +2     
- Partials      167      170       +3     
Impacted Files Coverage Δ
adaptive/tests/test_learners.py 98.98% <100.00%> (+<0.01%) ⬆️
adaptive/_version.py 45.61% <0.00%> (-3.51%) ⬇️
adaptive/learner/average_learner1D.py 77.66% <0.00%> (-0.67%) ⬇️
adaptive/learner/learner1D.py 89.13% <0.00%> (-0.25%) ⬇️
adaptive/runner.py 69.28% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt enabled auto-merge October 11, 2022 20:35
@basnijholt basnijholt merged commit 1b7e84d into main Oct 11, 2022
@basnijholt basnijholt deleted the optional-pandas-in-test branch October 11, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants