Skip to content

Remove unnecessary typing-extensions dependency#94

Merged
brandonwillard merged 1 commit intopythological:mainfrom
maresb:remove-typing-extensions
Aug 22, 2025
Merged

Remove unnecessary typing-extensions dependency#94
brandonwillard merged 1 commit intopythological:mainfrom
maresb:remove-typing-extensions

Conversation

@maresb
Copy link
Contributor

@maresb maresb commented Jun 24, 2025

typing.Literal was added in Python 3.8, and we require >=3.9, so typing-extensions is unneeded.

@maresb maresb changed the title Remove typing-extensions dependency Remove unnecessary typing-extensions dependency Jun 24, 2025
@brandonwillard brandonwillard force-pushed the remove-typing-extensions branch from 4eb6056 to 4285d9d Compare August 22, 2025 20:53
@brandonwillard brandonwillard enabled auto-merge (rebase) August 22, 2025 20:53
@maresb
Copy link
Contributor Author

maresb commented Aug 22, 2025

Thanks @brandonwillard!

I'm not sure why auto-merge failed here.

typing.Literal was added in Python 3.8, and we require >=3.9, so typing-extensions is unneeded.
@brandonwillard brandonwillard force-pushed the remove-typing-extensions branch from 4285d9d to 1519565 Compare August 22, 2025 23:01
@brandonwillard brandonwillard merged commit b1ff6cf into pythological:main Aug 22, 2025
11 checks passed
@maresb maresb deleted the remove-typing-extensions branch August 23, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants