This repository was archived by the owner on May 6, 2025. It is now read-only.
Add parsePriceFeedUpdates #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Nov 14, 2022
|
The value expected to be passed in the updateData array is the priceFeed data itself or the VAA? Also unrelated to this PR, but just realised the Price Struct in the sdk seems to not reflect the changed Price layout. |
It is the VAA. in the mock contract it is the encoded price feed as user does not care.
Yeah the Price here is a bit different than the way we store the price. We always construct these structs when user queries a price (or a pricefeed) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
parsePriceFeedUpdatesmethod to the Pyth interface.Some protocols need to access the price of a feed at a fixed point of time rather than the most recent one. This method will enable them to do so.
Also, this PR removes the transfer back logic as it is removed from the original contract to be consistent with Aptos.