This repository was archived by the owner on May 6, 2025. It is now read-only.
Refactor the interface #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has two purpose: 1) add priceFeedExists to handle the case when a price does not exist in `updatePriceIfNecessary`. try-catch doesn't work on local function call in solidity and we cannot catch the revert there. 2) getValidTimePeriod(): There are some cases that the previous getCurrentPrice implementation does not cover and it is better to use the latestAvailablePrice. However, we need to know the validity period and this is why it is added here. It uses the unsafe function to have better revert message if it occurs.
ali-behjati
requested review from
tompntn,
jayantk and
drozdziak1
and removed request for
tompntn and
jayantk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has two purpose:
in
updatePriceIfNecessary.try-catch doesn't work on local function call in solidity and we cannot
catch the revert there.
getCurrentPrice implementation does not
cover and it is better to use the latestAvailablePrice.
However, we need to know the validity period and this is why it is added
here. It uses the unsafe function to have better revert message if it
occurs.