Add zenduty integration #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
approved these changes
May 16, 2024
Contributor
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Looks good to me. Please address my inline comments before merging.
Can you also add some descriptions about this alert type + the env variables needed for it in the readme?
ali-behjati
reviewed
May 17, 2024
pyth_observer/zenduty.py
Outdated
| f"Received 429 Too Many Requests for {alert_identifier}. Retrying in 1 second..." | ||
| ) | ||
| await asyncio.sleep( | ||
| min(30, 2 ^ retries) |
Contributor
There was a problem hiding this comment.
i think this does the xor, should be 2**retries
ali-behjati
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Zenduty Event type, which requires us to manually resolve an incident once it surpasses so I have added logic to monitor open alerts and resolve them if the last alert was > 2 minutes ago. Open alerts are written to a file for persistence across app restarts, so we don't end up with orphaned unresolved incidents.