[hermes] Pass Wormhole arguments from command line or env. vars #769
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
hermes/src/config.rs
Outdated
|
|
||
| /// Multiaddresses for Wormhole bootstrap peers (separated by comma). | ||
| #[structopt(long, env = "WORMHOLE_BOOTSTRAP_ADDRS")] | ||
| wh_bootstrap_addrs: String, |
There was a problem hiding this comment.
This should be wh_bootstrap-addr: Vec<String> so the parser stays type-safe and is the structop/clap recommended way to do these arguments. The Vec<> way will also help structopt generate an informative --help message unlike the String and allows for:
prog
--wh-bootstrap-addr <foo> \
--wh-bootstrap-addr <foo> \
--wh-bootstrap-addr <foo> \
--wh-bootstrap-addr <foo>
As there's no real standard on multi-valued single parameters and --foo a,b,c does show up in other programs you can keep it this way if you prefer but I think It's less intuitive and doesn't match what a lot of more modern programs aim for.
There was a problem hiding this comment.
Good points. The downside is that it makes it harder to pass values using environment variables, but turns out that structopt supports it via https://docs.rs/clap/2.32.0/clap/struct.Arg.html#method.value_delimiter.
There was a problem hiding this comment.
Oh nice, TIL, had not seen this option, and the help doc generated looks good.
ali-behjati
changed the title
Change the p2p module to accept values for the Wormhole parameters.
First commit is just running gofmt (no changes to code).