feat(lazer-protocol): add utoipa schema to api types #3168
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lazer/sdk/rust/protocol/src/price.rs
Outdated
There was a problem hiding this comment.
The new schema declares Price as #[schema(value_type = i64)], yet ParsedFeedPayload (and other API structs) serialize Price using crate::serde_str::option_price, which converts the value to a string. The OpenAPI specification generated from this derive will advertise an integer while the WebSocket/HTTP payloads actually contain quoted strings, so clients generated from the spec will attempt to parse numbers and fail at runtime. Consider modelling the schema as a string (or overriding the field-level schema) so it matches the serialized representation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
👍 Please update the schema to use crate::serde_str::option_price
Summary
utoipa::ToSchematrait to api typesRationale
How has this been tested?