fix(entropy): Only mark callbacks as failed if enough gas was provided, regardless of revert code #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 7 Skipped Deployments
|
jayantk
commented
Oct 3, 2025
| assignedSequenceNumber, | ||
| userRandomNumber, | ||
| provider1Proofs[assignedSequenceNumber] | ||
| ); |
There was a problem hiding this comment.
this test used to fail before the change
tejasbadadare
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the check that allows us to mark callbacks as failed (even if enough gas wasn't provided) if they revert with a non-empty return code.
Rationale
When we wrote this initally, we thought that all out-of-gas reverts from calling contracts would bubble up and be caught by the
ret.length == 0condition. However, we have found that some contracts catch out-of-gas reverts and then revert with a different error code. This means we can end up calling these callbacks without enough gas.Simple fix here is to require enough gas to be provided regardless of the revert code.
How has this been tested?