Skip to content

Conversation

@Riateche
Copy link
Contributor

Summary

Remove constants and use values from config

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@Riateche Riateche requested a review from darunrs as a code owner September 29, 2025 15:21
@vercel
Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
api-reference Ready Ready Preview Comment Sep 29, 2025 3:25pm
component-library Ready Ready Preview Comment Sep 29, 2025 3:25pm
developer-hub Ready Ready Preview Comment Sep 29, 2025 3:25pm
entropy-explorer Ready Ready Preview Comment Sep 29, 2025 3:25pm
insights Ready Ready Preview Comment Sep 29, 2025 3:25pm
proposals Ready Ready Preview Comment Sep 29, 2025 3:25pm
staking Ready Ready Preview Comment Sep 29, 2025 3:25pm

darunrs
darunrs previously approved these changes Sep 29, 2025
@darunrs darunrs dismissed their stale review September 29, 2025 15:55

Config file isn't changed?

Copy link
Contributor

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the other config attr like cache dir, urls, and capacity also read? I only see changes for two of the attributes.

Copy link
Contributor

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sorry. Read through the current crosschain code. LGTM

@Riateche Riateche merged commit fe7d8d1 into main Sep 29, 2025
10 checks passed
@Riateche Riateche deleted the fix-lazer-history-client-config branch September 29, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants