Skip to content

test(fortuna): add unit tests for HashChainState #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 93 additions & 1 deletion apps/fortuna/src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ impl HashChainState {
#[cfg(test)]
mod test {
use {
crate::state::PebbleHashChain,
crate::state::{HashChainState, PebbleHashChain},
anyhow::Result,
sha3::{Digest, Keccak256},
};

Expand Down Expand Up @@ -202,4 +203,95 @@ mod test {
run_hash_chain_test([0u8; 32], 100, 50);
run_hash_chain_test([0u8; 32], 100, 55);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some tests for overlapping PebbleHashChains.

#[test]
fn test_hash_chain_state_from_chain_at_offset() {
let chain = PebbleHashChain::new([0u8; 32], 10, 1);
let hash_chain_state = HashChainState::from_chain_at_offset(5, chain);

assert_eq!(hash_chain_state.offsets.len(), 1);
assert_eq!(hash_chain_state.hash_chains.len(), 1);
assert_eq!(hash_chain_state.offsets[0], 5);
}

#[test]
fn test_hash_chain_state_reveal_valid_sequence() -> Result<()> {
let chain = PebbleHashChain::new([0u8; 32], 10, 1);
let expected_hash = chain.reveal_ith(3)?;

let hash_chain_state = HashChainState::from_chain_at_offset(5, chain);
let result = hash_chain_state.reveal(8)?;

assert_eq!(result, expected_hash);
Ok(())
}

#[test]
fn test_hash_chain_state_reveal_sequence_too_small() {
let chain = PebbleHashChain::new([0u8; 32], 10, 1);
let hash_chain_state = HashChainState::from_chain_at_offset(5, chain);

let result = hash_chain_state.reveal(4);
assert!(result.is_err());
}

#[test]
fn test_hash_chain_state_reveal_sequence_too_large() {
let chain = PebbleHashChain::new([0u8; 32], 10, 1);
let hash_chain_state = HashChainState::from_chain_at_offset(5, chain);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR but we should make this from_chain_at_offset function only for tests.


let result = hash_chain_state.reveal(15);
assert!(result.is_err());
}

#[test]
fn test_hash_chain_state_multiple_chains() -> Result<()> {
let chain1 = PebbleHashChain::new([0u8; 32], 10, 1);
let expected_hash1 = chain1.reveal_ith(3)?;

let chain2 = PebbleHashChain::new([1u8; 32], 10, 1);
let expected_hash2 = chain2.reveal_ith(3)?;

let hash_chain_state = HashChainState {
offsets: vec![5, 20],
hash_chains: vec![chain1, chain2],
};

let result1 = hash_chain_state.reveal(8)?;
assert_eq!(result1, expected_hash1);

let result2 = hash_chain_state.reveal(23)?;
assert_eq!(result2, expected_hash2);

let result_boundary = hash_chain_state.reveal(20)?;
let expected_boundary = hash_chain_state.hash_chains[1].reveal_ith(0)?;
assert_eq!(result_boundary, expected_boundary);

let result3 = hash_chain_state.reveal(15);
assert!(result3.is_err());

Ok(())
}

#[test]
fn test_hash_chain_state_overlapping_chains() -> Result<()> {
let chain1 = PebbleHashChain::new([0u8; 32], 10, 1);
let chain2 = PebbleHashChain::new([1u8; 32], 10, 1);

let hash_chain_state = HashChainState {
offsets: vec![5, 10],
hash_chains: vec![chain1, chain2],
};

let result1 = hash_chain_state.reveal(8)?;
let expected1 = hash_chain_state.hash_chains[0].reveal_ith(3)?;
assert_eq!(result1, expected1);

// returns the first offset that is > sequence_number)
let result2 = hash_chain_state.reveal(12)?;
let expected2 = hash_chain_state.hash_chains[1].reveal_ith(2)?;
assert_eq!(result2, expected2);

Ok(())
}
}
Loading