Skip to content

fix(pulse): update balance before parse call #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
+2 −2
Merged

fix(pulse): update balance before parse call #2694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ abstract contract Scheduler is IScheduler, SchedulerState {
// from the last trading period. Thus, we use a minimum timestamp of zero while parsing,
// and we enforce the past max validity ourselves in _validateShouldUpdatePrices using
// the highest timestamp in the update data.
status.balanceInWei -= pythFee;
status.totalSpent += pythFee;
uint64 curTime = SafeCast.toUint64(block.timestamp);
(
PythStructs.PriceFeed[] memory priceFeeds,
Expand All @@ -279,8 +281,6 @@ abstract contract Scheduler is IScheduler, SchedulerState {
0, // We enforce the past max validity ourselves in _validateShouldUpdatePrices
curTime + FUTURE_TIMESTAMP_MAX_VALIDITY_PERIOD
);
status.balanceInWei -= pythFee;
status.totalSpent += pythFee;

// Verify all price feeds have the same Pythnet slot.
// All feeds in a subscription must be updated at the same time.
Expand Down
Loading