Add Developer Hub to monorepo #2672
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/developer-hub/src/components/HomepageHero/HeroGraphic/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/HomepageHero/HeroGraphic/index.tsx
Outdated
Show resolved
Hide resolved
aaronbassett
force-pushed
the
devhub-boilerplate
branch
from
795cd76 to
0188575
Compare
aaronbassett
force-pushed
the
devhub-boilerplate
branch
from
0188575 to
60f0863
Compare
apps/developer-hub/next.config.js
Outdated
| @@ -0,0 +1,77 @@ | |||
| import createBundleAnalyzer from "@next/bundle-analyzer"; | |||
There was a problem hiding this comment.
Nice! Note that I'm working on moving other apps to using turbopack; I'm not sure how well this will work with turbopack, but in the meantime I think it would be great to roll it out across all our apps (obviously no need to do it in this PR but I'll be curious to see how you use the bundle analyzer and see if we want to leverage it elsewhere, so please let me know your thoughts when you get some more usage)
| var(--color-steel-50) | ||
| ); | ||
| --color-fd-ring: light-dark(var(--color-violet-600), var(--color-violet-400)); | ||
| } |
There was a problem hiding this comment.
Very nice! I suggest trying to use theme.scss to drive this file if possible -- in particular I think the whole color gradient can just use theme.pallette-color, and I think all the color tokens can be defined in terms of theme.color values right?
e.g. I would imagine this file could look something like this:
@use "@pythnetwork/component-library/theme";
:root {
--color-slate-50: theme.pallette-color("slate", 50);
...
--color-fd-background: theme.color("background", "primary");
}One thing to note is that once the new website gets rolled out, we will do a pass at adjusting the design system color tokens a bit to match with the new branding. If you implement in terms of all these tokes, it will mean less that we have to worry about manually syncing.
There was a problem hiding this comment.
I didn't want to spend any time on this part as I'm hoping @partyparrotgreg will replace it with the correct color mapping.
See feedback on PR #2672
Update start:dev and start:prod ports so they do not clash with Insights or other local apps.
| @@ -25,3 +25,4 @@ __pycache__ | |||
| .turbo/ | |||
| .cursorrules | |||
| .corepack | |||
| justfile | |||
There was a problem hiding this comment.
Hmm what is this? Is it intentional?
There was a problem hiding this comment.
Yeah, justfile is like a Makefile (but with a simplified syntax) it's a local command runner I use in terminal which probably isn't helpful to commit
There was a problem hiding this comment.
totally reasonable, feel free to commit files like this if you think they may be useful for others, for instance I've committed my nix files (flake.nix etc) -- maybe in a separate commit though
Summary
Minimal Developer Hub boilerplate with a basic content structure so we can begin Vercel deployments.