-
Notifications
You must be signed in to change notification settings - Fork 260
refactor(governance/xc_admin_frontend): refactor xc_admin_frontend to support lazer and other programs #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely getting a lot closer, but still a few things to fix. The most important things to me are to avoid using any
as much as possible (still a few places here that introduce it) and to avoid creating components in the render path of other componets.
I realize that a lot of this stuff was just moved around and isn't actually new code, so maybe it's best to leave the things that aren't net new alone and get this shipped, and to create a follow up PR to fix those patterns?
Summary
This PR introduces a modular architecture for supporting multiple Pyth programs (Pyth Core and Pyth Lazer) in our frontend application. Key changes include:
ProgramAdapter
interface and program-specific implementationsProgramType
enum to differentiate between Pyth Core and Pyth LazerRationale
These changes were necessary to:
How has this been tested?
Tested by: