Skip to content

chore(apps/price_pusher): update jito bundle endpoint #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

cctdaniel
Copy link
Contributor

Summary

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@cctdaniel cctdaniel requested a review from a team as a code owner March 28, 2025 09:52
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm
component-library ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm
insights ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm
proposals ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm
staking ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:34pm

@cctdaniel cctdaniel changed the title update jito bundle endpoint chore(apps/price_pusher): update jito bundle endpoint Mar 28, 2025
@@ -174,7 +174,7 @@ export class SolanaPricePusherJito implements IPricePusher {
async getRecentJitoTipLamports(): Promise<number | undefined> {
try {
const response = await fetch(
"http://bundles-api-rest.jito.wtf/api/v1/bundles/tip_floor",
"https://bundles.jito.wtf/api/v1/bundles/tip_floor",
);
if (!response.ok) {
this.logger.error(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we make it warning? because if it doesn't work we default to something else (and hopefully other alerts should catch it up if it results into not landing txs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup good point will make the change

Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like error better for easy detection

@cctdaniel cctdaniel merged commit 5cf22d9 into main Mar 28, 2025
4 of 10 checks passed
@cctdaniel cctdaniel deleted the solana-pusher-jito branch March 28, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants