feat(lazer): add ignoreInvalidFeedIds flag to SDK #2529

devin-ai-integration · 2025-03-27T18:35:05Z

This PR adds the ignoreInvalidFeedIds flag to the Lazer SDK to support the new feature in the Pyth Lazer router. When this flag is set to true, subscriptions will proceed with valid feeds and ignore invalid ones, returning categorized lists of successful and failed feeds.

Per user @darun Seethammagari (darun@dourolabs.xyz)'s request.

Link to Devin run: https://app.devin.ai/sessions/050e512b13ce4953bdcc8c4a2407c861

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel · 2025-03-27T18:35:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
proposals	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2025 2:35pm

5 Skipped Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview	Mar 31, 2025 2:35pm
component-library	⬜️ Ignored (Inspect)	Visit Preview	Mar 31, 2025 2:35pm
entropy-debugger	⬜️ Ignored (Inspect)	Visit Preview	Mar 31, 2025 2:35pm
insights	⬜️ Ignored (Inspect)	Visit Preview	Mar 31, 2025 2:35pm
staking	⬜️ Ignored (Inspect)	Visit Preview	Mar 31, 2025 2:35pm

devin-ai-integration · 2025-03-27T18:35:13Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

tejasbadadare · 2025-03-27T18:37:34Z

lazer/sdk/js/src/protocol.ts

@@ -47,6 +48,12 @@ export type JsonBinaryData = {
  data: string;
 };

+export type FailedFeedsDetails = {


suggest renaming this to InvalidFeedSubscriptionDetails

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T18:06:24Z

lazer/sdk/js/src/protocol.ts

+export type InvalidFeedSubscriptionDetails = {
+  unknownIds: number[];
+  unsupportedChannels: number[];
+  comingSoon: number[];


Keeping with the main PR, can you change this to "unstable"?

…ails Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T18:23:15Z

lazer/sdk/rust/protocol/src/subscription.rs

@@ -50,6 +52,10 @@ pub enum Response {
 #[serde(rename_all = "camelCase")]
 pub struct SubscribedResponse {
    pub subscription_id: SubscriptionId,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub successful_feeds: Option<Vec<u64>>,


Change this to a vec of u32

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

lazer/sdk/js/src/protocol.ts

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T18:33:49Z

lazer/sdk/js/src/protocol.ts

@@ -56,6 +63,12 @@ export type Response =
      type: "subscribed";
      subscriptionId: number;
    }
+  | {
+      type: "subscribedWithIgnoredFailures";


Err sorry let's actually do "subscribedWithInvalidFeeds" instead.

…idFeeds Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

lazer/sdk/js/src/protocol.ts

darunrs · 2025-03-28T18:43:14Z

lazer/sdk/js/src/protocol.ts

@@ -56,6 +63,12 @@ export type Response =
      type: "subscribed";
      subscriptionId: number;
    }
+  | {
+      type: "subscribedWithInvalidFeeds";


one last rename. Let's call this "subscribedWithInvalidFeedIdsIgnored".

darunrs · 2025-03-28T18:44:40Z

lazer/sdk/rust/protocol/src/subscription.rs

@@ -50,6 +52,10 @@ pub enum Response {
 #[serde(rename_all = "camelCase")]
 pub struct SubscribedResponse {


SubscribedResponse should be unchanged. Add a new struct called SubscribedWithInvalidFeedIdsIgnored. It should match the new structure that is in the JS protocol.

…nvalidFeedIds Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T19:05:14Z

lazer/sdk/js/src/protocol.ts

+      successfulFeeds: number[];
+      failedFeeds: InvalidFeedSubscriptionDetails;


Rename successfulFeeds to "subscribedFeedIds" and rename failedFeeds to "ignoredInvalidFeedIds"

darunrs · 2025-03-28T19:08:18Z

lazer/sdk/rust/protocol/src/subscription.rs

+pub struct SubscribedWithInvalidFeedIdsIgnoredResponse {
+    pub subscription_id: SubscriptionId,
+    pub successful_feeds: Vec<u32>,
+    pub failed_feeds: serde_json::Value,


Add a struct for the failed_feeds called InvalidFeedSubscriptionDetails with the same equivalent type as the JS protocol version. Also, rename successful_feeds to "subscribed_feed_ids" and rename failed_feeds to "ignored_invalid_feed_ids".

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T19:16:23Z

lazer/sdk/rust/protocol/src/subscription.rs

@@ -40,6 +42,7 @@ pub struct UnsubscribeRequest {
 pub enum Response {
    Error(ErrorResponse),
    Subscribed(SubscribedResponse),
+    SubscribedWithIgnoredInvalidFeedIds(SubscribedWithInvalidFeedIdsIgnoredResponse),


Name this "SubscribedWithInvalidFeedIdsIgnored". The response is named correctly.

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T20:20:24Z

The ignore_invalid_feed_ids field needs to be a part of the SubscriptionParams struct.

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs · 2025-03-28T22:20:02Z

lazer/sdk/rust/protocol/src/router.rs

@@ -358,6 +358,8 @@ pub struct SubscriptionParamsRepr {
    #[serde(default = "default_parsed")]
    pub parsed: bool,
    pub channel: Channel,
+    #[serde(default)]
+    pub ignore_invalid_feed_ids: Option<bool>,


There is no point to this being an option. Make it a bool and the serde default should default to false. Customers using the old version should submit the old SubscriptionParams struct and it should be deserialized in the Lazer service, defaulting the ignore field if not present.

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

lazer/sdk/js/src/protocol.ts

merolish

lgtm!

devin-ai-integration · 2025-03-29T00:24:28Z

Yes, these are lists of feed IDs categorized by error type:

unknownIds: Feed IDs that don't exist in the system
unsupportedChannels: Feed IDs that don't support the requested channel
unstable: Feed IDs marked as "Coming Soon" (unstable feeds)

This categorization provides better customer UX by giving specific information about why each feed ID failed, rather than just a generic error.

Riateche · 2025-03-31T09:26:41Z

lazer/sdk/rust/protocol/src/subscription.rs

+    pub unknown_ids: Vec<u32>,
+    pub unsupported_channels: Vec<u32>,
+    pub unstable: Vec<u32>,


These fields should use PriceFeedId and Channel types.

Riateche · 2025-03-31T09:27:04Z

lazer/sdk/rust/protocol/src/subscription.rs

+#[serde(rename_all = "camelCase")]
+pub struct SubscribedWithInvalidFeedIdsIgnoredResponse {
+    pub subscription_id: SubscriptionId,
+    pub subscribed_feed_ids: Vec<u32>,


Suggested change

pub subscribed_feed_ids: Vec<u32>,

pub subscribed_feed_ids: Vec<PriceFeedId>,

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

devin-ai-integration bot and others added 4 commits March 27, 2025 17:52

feat(lazer): add ignoreInvalidFeeds flag to SDK

c194872

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

feat(lazer): update protocol types for ignore_invalid_feeds

7d7078f

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

fix: update example to include ignore_invalid_feeds field

a8e1e90

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

refactor: rename ignore_invalid_feeds to ignore_invalid_feed_ids

2d4f5b7

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 27, 2025 18:37 View deployment

tejasbadadare reviewed Mar 27, 2025

View reviewed changes

refactor: rename FailedFeedsDetails to InvalidFeedSubscriptionDetails

6b736af

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 27, 2025 18:44 View deployment

tejasbadadare approved these changes Mar 27, 2025

View reviewed changes

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: rename comingSoon to unstable in InvalidFeedSubscriptionDet…

c436bff

…ails Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 28, 2025 18:12 View deployment

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: change successful_feeds type from Vec<u64> to Vec<u32>

23b6f5d

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs reviewed Mar 28, 2025

View reviewed changes

lazer/sdk/js/src/protocol.ts Show resolved Hide resolved

refactor: add subscribedWithIgnoredFailures response type

be328ab

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: rename subscribedWithIgnoredFailures to subscribedWithInval…

545cfbb

…idFeeds Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 28, 2025 18:39 View deployment

darunrs reviewed Mar 28, 2025

View reviewed changes

devin-ai-integration bot and others added 2 commits March 28, 2025 18:45

refactor: rename subscribedWithInvalidFeeds to subscribedWithIgnoredI…

9b1d540

…nvalidFeedIds Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

refactor: rename response types to subscribedWithInvalidFeedIdsIgnored

ba506a5

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 28, 2025 18:52 View deployment

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: rename fields to subscribedFeedIds and ignoredInvalidFeedIds

8d96275

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 28, 2025 19:14 View deployment

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: rename enum variant to SubscribedWithInvalidFeedIdsIgnored

2d89de1

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

refactor: move ignore_invalid_feed_ids to SubscriptionParamsRepr

99b6bd1

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs reviewed Mar 28, 2025

View reviewed changes

refactor: change ignore_invalid_feed_ids from Option<bool> to bool

ebd4a93

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

darunrs requested a review from tejasbadadare March 29, 2025 00:06

merolish reviewed Mar 29, 2025

View reviewed changes

lazer/sdk/js/src/protocol.ts Show resolved Hide resolved

merolish approved these changes Mar 29, 2025

View reviewed changes

Riateche requested changes Mar 31, 2025

View reviewed changes

refactor: update InvalidFeedSubscriptionDetails to use proper types

62eeb1c

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 31, 2025 09:40 View deployment

devin-ai-integration bot and others added 2 commits March 31, 2025 09:58

refactor: use local SymbolState instead of external dependency

82728e3

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

fix: update protocol.ts formatting to fix CI

e7e626e

Co-Authored-By: Darun Seethammagari <darun@dourolabs.xyz>

vercel bot deployed to Preview – proposals March 31, 2025 10:06 View deployment

Undo change ot returned ignored ids

3f30ea2

darunrs requested a review from a team as a code owner March 31, 2025 14:31

vercel bot deployed to Preview – proposals March 31, 2025 14:35 View deployment

Riateche approved these changes Mar 31, 2025

View reviewed changes

darunrs merged commit ba09a52 into main Mar 31, 2025
11 checks passed

darunrs deleted the devin/1743097867-ignore-invalid-feed-ids branch March 31, 2025 19:18

		@@ -50,6 +52,10 @@ pub enum Response {
		#[serde(rename_all = "camelCase")]
		pub struct SubscribedResponse {

		successfulFeeds: number[];
		failedFeeds: InvalidFeedSubscriptionDetails;

	pub subscribed_feed_ids: Vec<u32>,
	pub subscribed_feed_ids: Vec<PriceFeedId>,

feat(lazer): add ignoreInvalidFeedIds flag to SDK #2529

feat(lazer): add ignoreInvalidFeedIds flag to SDK #2529

Uh oh!

Conversation

devin-ai-integration bot commented Mar 27, 2025

Uh oh!

vercel bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot commented Mar 27, 2025

🤖 Devin AI Engineer

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darunrs Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darunrs Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darunrs commented Mar 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

merolish left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot commented Mar 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Mar 27, 2025 •

edited

Loading

darunrs Mar 28, 2025 •

edited

Loading

darunrs Mar 28, 2025 •

edited

Loading