Only build stuff that requires Vercel env to build on Vercel #2524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
force-pushed
the
cprussin/dont-build-vercel-stuff
branch
from
11aa888 to
4ccde52
Compare
cprussin
force-pushed
the
cprussin/dont-build-vercel-stuff
branch
from
4ccde52 to
14db426
Compare
cprussin
force-pushed
the
cprussin/dont-build-vercel-stuff
branch
from
14db426 to
817a02b
Compare
For many of our UI applications, in order to build the package, a number of environment variables must be present. The values for these env vars are stored in Vercel, however not everyone who contributes to this repository will have access to Vercel. This PR modifies the turbo config to not build those packages on `turbo build`. This is generally probably the right thing since we don't want those packages to build in Github Actions either, given the environment is not going to be present in GHA and so the builds would likely fail there too. After this PR, to build any packages that rely on Vercel environments, you will run `turbo build:vercel`. Running `turbo build` will build everything else and will exclude anything that depends on the Vercel env.
cprussin
force-pushed
the
cprussin/dont-build-vercel-stuff
branch
from
817a02b to
49e88fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not build packages that rely on the Vercel environment using
turbo build, instead move them to build withturbo build:vercelRationale
For many of our UI applications, in order to build the package, a number of environment variables must be present.
The values for these env vars are stored in Vercel, however not everyone who contributes to this repository will have access to Vercel.
This PR modifies the turbo config to not build those packages on
turbo build. This is generally probably the right thing since we don't want those packages to build in Github Actions either, given the environment is not going to be present in GHA and so the builds would likely fail there too.After this PR, to build any packages that rely on Vercel environments, you will run
turbo build:vercel. Runningturbo buildwill build everything else and will exclude anything that depends on the Vercel env.How has this been tested?
CI will be the test