chore: update all app node dependencies #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates all apps to using exclusively catalog dependencies, and upgrades all catalog dependencies.
This PR separates type imports from value imports, in compliance with a newly enforced eslint rule from the new @cprussin configs. This rule is important as it helps prevent cases where tree shaking is less effective due to modules getting included in the runtime build which are in fact only used for type imports.
The main disable here is disabling unicorn/prefer-math-min-max where it would downcast bigints to numbers.
There were a few @ts-expect-error and eslint-disable lines caused by typings which have been now fixed in the underlying libraries and so we can now remove those annotatinos.
The upgraded react-aria library comes with much upgraded Toast apis, so this commit moves us to take advantage of those
This commit fixes places where we were using deprecated APIs or misusing types which can now be caught with our upgraded typescript parser.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
cprussin
changed the title
This breaks `turbo-ignore`'s ability to detect the turbo version and results in Vercel being unable to skip unneeded builds. See vercel/turborepo#10048
cprussin
force-pushed
the
cprussin/ui-24-update-dependencies
branch
from
9352d18 to
8c2e938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEAR REVIEWER: please note I've painstakingly split this PR into commits that are logically separated. It should be fairly easy to review if you look through commit-by-commit -- many of the commits are just the same mechanical change applied to the whole monorepo....
Summary
This PR moves all of our web apps to using exclusively catalog dependencies and upgrades all catalog dependencies to latest verisons.
While doing this, this PR also includes fixes (mostly automated) for newly enforced eslint rules, stricter typechecking introduced by the upgraded typescript version, and improved prettier formatting in some places. This PR also migrates some code to remove deprecated API usage and take advantage of newer lib features in a few of our libs where appropriate.
Rationale
There are a number of reasons to get this upgrade done:
@cprussintool configs and the newer version resolves a few dependency pinning issues that we'd been working aroundAlso fixes UI-25
How has this been tested?