Skip to content

deprecate(pyth-evm-js): Add deprecation notice #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2025

Conversation

aditya520
Copy link
Member

Summary

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am
component-library ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am
insights ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am
proposals ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am
staking ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 3:22am

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix ci and address my comment before merging

@@ -14,7 +14,6 @@ packages:
- "target_chains/ethereum/contracts"
- "target_chains/ethereum/abi_generator"
- "target_chains/ethereum/entropy_sdk/solidity"
- "target_chains/ethereum/sdk/js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please still keep it here so we can publish the package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier is messing up with the warning sign I put in the readme.

@aditya520 aditya520 force-pushed the chore(ethereum)-deprecate-pyth-evm-js branch from 7eaa218 to b26eddd Compare March 14, 2025 20:13
@aditya520 aditya520 merged commit ba49373 into main Mar 17, 2025
9 checks passed
@aditya520 aditya520 deleted the chore(ethereum)-deprecate-pyth-evm-js branch March 17, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants