feat(target_chains/sui): Use Turbo for Commands #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
cprussin
approved these changes
Mar 11, 2025
| @@ -49,7 +50,8 @@ async function run() { | |||
|
|
|||
| // Fetch the latest price feed update data from the Price Service | |||
| const connection = new SuiPriceServiceConnection(argv["hermes"]); | |||
| const feeds = argv["feed-id"] as string[]; | |||
| const feeds = argv["feed-id"]; | |||
| if (!Array.isArray(feeds)) { throw new Error("Not a valid input!"); } | |||
There was a problem hiding this comment.
I think this will fail prettier, try running pnpm turbo fix
There was a problem hiding this comment.
Ran the command in root and it surprisingly did not complain about or change anything. Also in the two packages I changed, and no changes.
There was a problem hiding this comment.
ah right this package has the legacy pre-commit based prettier config, instead run pre-commit run --all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated SUI JS SDK and CLI to use Turbo to help with dependency management. Updated the README to reflect this. Also fixed the relay example to use feed ids as string instead of number.
Rationale
There were a litany of issues getting the SUI JS SDK and CLI to work at all. I got help from Connor to figure out what is wrong and how to fix it. Now, the examples should work out of box and without too much trouble.
How has this been tested?
Manually tested by cleaning up repo locally using
git clean -fdxand then installing with pnpm in root. Then, running examples and cli commands using turbo successfully.