refactor: move wormhole attester to pythnet_sdk legacy module #2353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Move wormhole_attester code to pythnet_sdk/legacy - Update downstream dependencies - Delete original wormhole_attester directory Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
jayantk
reviewed
Feb 7, 2025
pythnet/pythnet_sdk/Cargo.toml
Outdated
| serde_wormhole = {version ="0.1.0", optional = true} | ||
| wormhole-vaas-serde = {version = "0.1.0", optional = true} | ||
| libsecp256k1 = {version ="0.7.1", optional = true} | ||
| rand = {version = "0.8.5", optional = true} | ||
| solana-program = {version = ">=1.13.6", optional = true} | ||
| solana-program = { version = ">=1.14.6", optional = true } |
There was a problem hiding this comment.
Please don't change the versions of these dependencies.
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
jayantk
reviewed
Feb 7, 2025
| @@ -33,18 +33,16 @@ generic-array = { version = "0.14.4" } | |||
| hex = "0.4.2" | |||
| lazy_static = "1.4.0" | |||
| bigint = "4" | |||
| pyth-wormhole-attester-sdk = { path = "../../../../wormhole_attester/sdk/rust" } | |||
There was a problem hiding this comment.
Please bump the patch version of this file.
…fier Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
Co-Authored-By: Jayant Krishnamurthy <jayant@dourolabs.xyz>
jayantk
force-pushed
the
devin/1738954977-move-wormhole-attester-to-legacy
branch
from
7c91674 to
25fa03e
Compare
Riateche
requested changes
Feb 10, 2025
| @@ -1346,18 +1423,18 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "home" | |||
| version = "0.5.9" | |||
| version = "0.5.11" | |||
There was a problem hiding this comment.
This upgrades a dependency to a version that doesn't build on the pinned toolchain version, so the CI fails. Either revert the dependency update or bump the toolchain version.
jayantk
force-pushed
the
devin/1738954977-move-wormhole-attester-to-legacy
branch
from
3fed4fd to
6a19007
Compare
Riateche
approved these changes
Feb 12, 2025
jayantk
deleted the
devin/1738954977-move-wormhole-attester-to-legacy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move wormhole_attester code to pythnet_sdk/legacy module
Link to Devin run: https://app.devin.ai/sessions/a17618f07a054fbd8d28c57a4eedf941
Requested by: Jayant