Skip to content

feat(target_chains/near): add reproducible build #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Feb 6, 2025

No description provided.

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:37am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:37am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:37am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:37am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:37am
insights ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:37am

image = "sourcescan/cargo-near:0.13.3-rust-1.84.1"
image_digest = "sha256:baa712c5d2b7522d38175e36330d336ad2c4ce32bfaaa41af94ce40407ecd803"
passed_env = []
container_build_command = ["cargo", "near", "build", "non-reproducible-wasm", "--locked"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such a strange thing: the reproducible build runs non-reproducible-wasm build command lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the difference between them is that reproducible-wasm spins up a docker container, so it makes sense that it's not needed inside the container.

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Maybe update the readme or build scripts to use this as well?

@Riateche
Copy link
Contributor Author

Riateche commented Feb 7, 2025

I updated the readme and removed a stale deploy script (now it's just a single command that's in the readme). I'll update the upgrade scripts later.

@Riateche Riateche force-pushed the near-reproducible-build branch from 8feda88 to 94f9b50 Compare February 7, 2025 12:34
@Riateche Riateche merged commit c171c3e into main Feb 7, 2025
10 checks passed
@Riateche Riateche deleted the near-reproducible-build branch February 7, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants