-
Notifications
You must be signed in to change notification settings - Fork 261
feat(contract_manager): add near chains and contracts #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some minor comments, please address them before merging.
return { id: outcome.transaction.hash, info: outcome }; | ||
} | ||
|
||
getCurrentGuardianSetIndex(): Promise<number> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so there is no way to check this out? strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is no method for this.
throw new Error( | ||
"near contract doesn't implement getGovernanceDataSource method" | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know how the upgrade is going to work? we initially execute governance instruction, but what can we do after it :?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we'll need to call a permissionless method update_contract
with the new wasm file as input.
@@ -19,6 +19,7 @@ export const RECEIVER_CHAINS = { | |||
aurora: 9, | |||
fantom: 10, | |||
celo: 14, | |||
near: 15, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we are not using our own version of wormhole receiver here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think we're using wormhole's own contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this one has the list of the ones that we manage the wh contract. (see the comment above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to a separate section with a comment.
3d44f78
to
6201e3f
Compare
No description provided.