Skip to content

feat(contract_manager): add near chains and contracts #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Feb 5, 2025

No description provided.

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:56am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:56am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:56am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:56am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:56am
insights ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:56am

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some minor comments, please address them before merging.

return { id: outcome.transaction.hash, info: outcome };
}

getCurrentGuardianSetIndex(): Promise<number> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there is no way to check this out? strange.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is no method for this.

throw new Error(
"near contract doesn't implement getGovernanceDataSource method"
);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know how the upgrade is going to work? we initially execute governance instruction, but what can we do after it :?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to call a permissionless method update_contract with the new wasm file as input.

@@ -19,6 +19,7 @@ export const RECEIVER_CHAINS = {
aurora: 9,
fantom: 10,
celo: 14,
near: 15,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we are not using our own version of wormhole receiver here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think we're using wormhole's own contract.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this one has the list of the ones that we manage the wh contract. (see the comment above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to a separate section with a comment.

@Riateche Riateche deleted the contract-manager-near branch February 7, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants