fix(insights): remove data caching & pregeneration, add revalidate #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
These features aren't scaling well as the number of price feeds grows: - The data cache doesn't seem to be reliably revalidating as expected, probably due to it being an experimental nextjs feature. Given the [new model for caching](https://nextjs.org/blog/composable-caching) that is coming in an upcoming nextjs release, I think it best to just remove the experimental caching until that lands. - The pregeneration is starting to take way too long as the number of price feeds grows drastically. Instead, this PR adds `revalidate` to routes that use API data for server-generation. This should avoid data cache issues while still serving pages from cache and regenerating them every hour. The initial page load will be slower since we aren't pregenerating any more, but subsequent page loads will be served from cache. If things still feel too slow, I'll investigate other solutions
cprussin
force-pushed
the
cprussin/fix-insights-cache
branch
from
ccc7036 to
517962f
Compare
cprussin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features aren't scaling well as the number of price feeds grows:
The data cache doesn't seem to be reliably revalidating as expected, probably
due to it being an experimental nextjs feature. Given the new model for
caching that is coming in an
upcoming nextjs release, I think it best to just remove the experimental caching
until that lands.
The pregeneration is starting to take way too long as the number of price
feeds grows drastically.
Instead, this PR adds
revalidateto routes that use API data forserver-generation. This should avoid data cache issues while still serving
pages from cache and regenerating them every hour. The initial page load will
be slower since we aren't pregenerating any more, but subsequent page loads will
be served from cache.
If things still feel too slow, I'll investigate other solutions