fix(hermes): make ignore_invalid_price_ids param optional on the stream API
#2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
keyvankhademi
approved these changes
Nov 6, 2024
tejasbadadare
deleted the
tb/hermes/fix_ignore_invalid_price_ids_required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught a bug when testing #2091 on testnet -- the
ignore_invalid_price_idsparam is required on the stream API when it should have been optional. This was raised by @keyvankhademi in the original PR, but it looks like I crossed some wires in my git operations and the commit didn't end up in the branch before I merged it. Thanks to @ayazabbas for the tip on testing the release on testnet first, it helped out here :)