Skip to content

add calendar for pyth market hours #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

add calendar for pyth market hours #31

merged 2 commits into from
Jun 14, 2023

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Jun 14, 2023

creating a centralized place for calendar which is used to calculate pyth price feeds market hours so that other repositories can depend on this instead of having multiple copies of the same file

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it may be smart to move this python library into pyth-crosschain also so it's easier use.

return True

# all other markets (crypto)
return True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may want to add a function like next_close_time in here also

@cctdaniel cctdaniel merged commit b97aad1 into main Jun 14, 2023
@cctdaniel cctdaniel deleted the calendar branch June 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants