Skip to content

return timestamp and prev_timestamp #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2022
Merged

return timestamp and prev_timestamp #27

merged 3 commits into from
Jul 24, 2022

Conversation

cctdaniel
Copy link
Contributor

I noticed that prev_slot, prev_price, and prev_conf weren't returned previously -- was there any particular reason for doing so? if not I can implement them in a separate PR

note: timestamp returned is unix timestamp in seconds

@cctdaniel cctdaniel requested review from jayantk and ali-behjati July 24, 2022 10:15
@cctdaniel cctdaniel self-assigned this Jul 24, 2022
jayantk
jayantk approved these changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think these fields and the prev_ ones you mentioned were all added after we created this API, and we just forgot to update it.

@cctdaniel
Copy link
Contributor Author

got it - I'll open a separate PR to implement them

@cctdaniel cctdaniel merged commit 30303a1 into main Jul 24, 2022
@cctdaniel cctdaniel deleted the timestamp branch July 24, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

@ali-behjati ali-behjati Awaiting requested review from ali-behjati

Assignees

@cctdaniel cctdaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cctdaniel @jayantk