add tests for PythClient and PythAccount #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEJeff
reviewed
Dec 1, 2021
| assert ratelimit._get_overall_interval() == 1.0 | ||
| assert ratelimit._get_method_interval() == 1.0 | ||
| assert ratelimit._get_connection_interval() == 1.0 | ||
|
|
SEJeff
reviewed
Dec 1, 2021
| # 1) these values are not expected to be mutated | ||
| # 2) these values are used in get_account_info_resp() and get_program_accounts_resp() | ||
| # and so if they are passed in as fixtures, the functions will complain for the args | ||
| # while mocking the respective functions |
There was a problem hiding this comment.
👍 this is a good comment. Makes maintaining things in the future much easier.
Co-authored-by: Jeff Schroeder <jeffschroeder@computer.org>
Co-authored-by: Jeff Schroeder <jeffschroeder@computer.org>
Co-authored-by: Jeff Schroeder <jeffschroeder@computer.org>
Co-authored-by: Jeff Schroeder <jeffschroeder@computer.org>
cctdaniel
force-pushed
the
daniel-tests
branch
from
5c0dc60 to
28ed984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressed #9 comments by @SEJeff