chore: Bump Rust edition and Solana crates #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merolish
commented
Apr 25, 2025
merolish
commented
- Bump Rust edition to 2024
- Bump Solana client crates to 2.2 to align with pyth-sdk-solana
- fmt (mainly rearrangement of imports)
- Some clippy allowances
- ed25519-dalek v2 updates
keyvankhademi
previously approved these changes
Apr 25, 2025
|
lgtm. But wait for someone else to review too. |
darunrs
approved these changes
Apr 26, 2025
| @@ -210,6 +210,7 @@ where | |||
| handles | |||
| } | |||
|
|
|||
| #[allow(clippy::module_inception)] | |||
There was a problem hiding this comment.
Why are we getting this clippy problem now?
There was a problem hiding this comment.
As far as I can tell these have been existing issues and clippy isn't a PR check.
|
Also this probably qualifies for a version bump too. |
|
Good point on the version bump. Unit and integration tests are run; see workflows/rust.yaml, although I cannot vouch for how thorough they are and they also don't include the lazer side yet. We will need to properly test this prior to distributing the new version. |
|
(The integration test stuff is in integration-test, which mocks a pythnet node in Python.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.