feat: RPC redundancy #157
feat: RPC redundancy #157
Conversation
| # rate-limited, so a private endpoint should be used in most cases. | ||
| rpc_url = "https://api2.pythnet.pyth.network" | ||
| # API calls will cycle through each on failure. | ||
| rpc_urls = ["https://api2.pythnet.pyth.network"] |
There was a problem hiding this comment.
This breaks backward compatibility, let's bump the version as a major one. (we can ship it with lazer in one go)
src/agent/solana.rs
Outdated
| #[serde(default = "default_rpc_url")] | ||
| pub rpc_url: String, | ||
| pub rpc_urls: Vec<String>, |
There was a problem hiding this comment.
Can we take our chance here to convert it to Vec?
There was a problem hiding this comment.
Do you mean the websocket list below, or something else?
There was a problem hiding this comment.
oh sorry my bad, i wanted to say to convert it to Vec of Url :D (because we pass string everywhere and it's not great)
There was a problem hiding this comment.
Yep. It looks like the solana rpc client can directly take in Urls as of version 2, so I'll make that change in the wrapper struct when I'm able to bump the solana crates.
src/agent/services/exporter.rs
Outdated
| let current_slot_future = | ||
| self.rpc_clients[0].get_slot_with_commitment(CommitmentConfig::confirmed()); | ||
| let latest_blockhash_future = self.rpc_clients[0].get_latest_blockhash(); |
There was a problem hiding this comment.
it's important for this to work properly as the data from these two are used in the transactions. Please loop through urls
| @@ -83,6 +84,12 @@ where | |||
| tracing::warn!(?sleep_time, "Subscriber restarting too quickly. Sleeping"); | |||
| tokio::time::sleep(sleep_time).await; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
maybe also add a log to say which one failed?
…pc-redundancy # Conflicts: # Cargo.lock
Change rpc_url to rpc_urls and for all calls, cycle through them until first success.