Skip to content

Fix program_id to be a pubkey instead of a string #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Dec 21, 2022

In two places of the code set_minimum_publishers is being called program_id being a string instead of a Publickey.
This made other changes I wanted to make break.

I don't know how or if python can catch these type mismatchs.

@thmzlt
Copy link
Contributor

thmzlt commented Dec 21, 2022

If you install the pylance and python VS code extensions, and start VS Code with poetry run code . from the project directory, it should detect type mismatches.

Also, we should eventually define a type for the instruction output.

@guibescos guibescos merged commit b689c44 into main Dec 21, 2022
@guibescos guibescos deleted the guibescos/feed-program-id-as-pubkey branch December 21, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants