Skip to content

Only sign with the keypairs that need to sign #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Dec 21, 2022

Currently, all signers for a given list of instructions sign all the resulting transactions.
However, the list of instructions can get split in multiple transactions (when the list exceeds the maximum transaction size) and in that case we don't want all the signers to sign each transaction but only those that actually appear in the transaction.

@guibescos guibescos changed the title Fix signature logic Only sign with the pubkeys that need to sign Dec 21, 2022
@guibescos guibescos changed the title Only sign with the pubkeys that need to sign Only sign with the keypairs that need to sign Dec 21, 2022
@guibescos guibescos merged commit b85966b into main Dec 21, 2022
@guibescos guibescos deleted the guibescos/only-get-needed-signatures branch December 21, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants