main: avoid Path(Path(...)) calls, they're slow #9147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Oct 1, 2021
|
|
||
| def gethookproxy(self, fspath: "os.PathLike[str]"): | ||
| # Optimization: Path(Path(...)) is much slower than isinstance. | ||
| path = fspath if isinstance(fspath, Path) else Path(fspath) |
There was a problem hiding this comment.
Perhaps create a make_path function (or something like that)? I understand only two places do this right now, however having a function brings some advantages:
- We have place to put that comment about optimization.
- Encourages others in the future to use the function, instead of copying/pasting the same two lines.
There was a problem hiding this comment.
I thought about it, but decided against it:
- I think in most cases it is not performance critical, so would just obfuscate the code
- The function call itself might have some overhead
So I just went with repeating in these two places. However, if there is ever a third we probably should.
nicoddemus
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for reference #9125. From my measurements it is not that extreme, however I can confirm it shaves off ~5s from pandas collection time.