Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin towncrier to 18.6.0 due to twisted/towncrier#346 #9045

Closed
wants to merge 2 commits into from

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 27, 2021

This also adds the missing changelog entry for #9040 (in a separate commit).

Close #8817

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 27, 2021
The-Compiler added a commit to The-Compiler/pytest that referenced this pull request Aug 27, 2021
@nicoddemus
Copy link
Member Author

@The-Compiler I noticed this:

image

Want me to remove that bit from this PR?

Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a proper fix for this instead: #9046

@nicoddemus
Copy link
Member Author

Thanks @The-Compiler!

@nicoddemus nicoddemus closed this Aug 27, 2021
@nicoddemus nicoddemus deleted the towncrier-pin-trivial branch August 27, 2021 12:57
The-Compiler added a commit to The-Compiler/pytest that referenced this pull request Nov 8, 2021
The-Compiler added a commit that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out how to fix changelog title
3 participants