Fix Module.name from full path without drive letter #7643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
Aug 14, 2020
nicoddemus
added
the
needs backport
Member
Author
|
Decided to refactor |
bluetech
approved these changes
Aug 15, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Left some comments, and CI seems to be failing, but +1 from on the fix and the split to standalone functions.
| def resolve_path_argument( | ||
| invocation_dir: py.path.local, arg: str, *, as_pypath=False | ||
| ) -> Tuple[py.path.local, List[str]]: | ||
| """Parse path arguments optionally containing selection parts and return (fspath, names). |
Member
Author
|
Hmmm I was hoping to backport this, but this would also need the pathlib improvements we have on master right now (notably |
nicoddemus
removed
the
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7628