Add support for NO_COLOR and FORCE_COLOR #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
changed the title
nicoddemus
approved these changes
Jul 8, 2020
Added! Should they be in alphabetical order? For example, before:
After:
|
hugovk
commented
Jul 9, 2020
hugovk
commented
Jul 9, 2020
Good catch, I think so, perhaps except keeping the pytest-specific ones separated from the others:
Also the non-pytest specific could be order by precedence perhaps?
What do you think? |
|
Done! |
nicoddemus
reviewed
Jul 10, 2020
|
Thanks @hugovk! |
blueyed
reviewed
Jul 10, 2020
| @@ -0,0 +1,3 @@ | |||
| Added support for ``NO_COLOR`` and ``FORCE_COLOR`` environment variables to control colored output. | |||
|
|
|||
| For more information, see `the docs <https://docs.pytest.org/en/stable/reference.html#environment-variables>`__. | |||
There was a problem hiding this comment.
This could/should use an internal reference (Python uses using-on-envvars).
In general (internal) documentation links should not go through external resources/protocols.
There was a problem hiding this comment.
True, that escaped my mind, thanks. 👍
This was referenced Sep 9, 2020
1 task
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7464.
PY_COLORSis pytest-specific and comes first (#7464 (comment)).Then
NO_COLORtakes precendece overFORCE_COLOR(like tartley/colorama#230).Then check the other rules.
Also includes the Jython removal from #7462.