Skip to content

Fix favicon for Chrome and Opera #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Fix favicon for Chrome and Opera #6639

merged 2 commits into from
Jan 31, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 31, 2020

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features, improvements, and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • [n/a?] Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

    Write sentences in the past or present tense, examples:

    • Improved verbose diff output with sequences.
    • Terminal summary statistics now use multiple colors.

    Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.


Old favicon

Right now, the favicon shows as a blank white box in Chrome and Opera. It's fine in Firefox.

The old doc/en/img/pytest1favi.ico from 2014 has two frames, one Pytest logo with a transparent background and one plain white box.

image

Different browsers pick a different frame.

macOS Chrome 79

image

macOS Opera 65

image

macOS Firefox 72

image

Android Chrome 79

image

New favicon

Converted to PNG frames using ImageMagick, updated config to use the logo frame:

convert doc/en/img/pytest1favi.ico favicon.png
cp favicon-0.png doc/en/img/favicon.png
sphinx-build -W --keep-going -b html doc/en doc/en/_build -t changelog_towncrier_draft
open doc/en/_build/index.html

The conf.py comments say "This file should be a Windows icon file (.ico) being 16x16 or 32x32 pixels large", but PNG works fine in 2020.

macOS Chrome 79

image

macOS Opera 65

image

macOS Firefox 72

image

TODO

  • Remove old file?

@hugovk hugovk added the type: docs documentation improvement, missing or needing clarification label Jan 31, 2020
@nicoddemus
Copy link
Member

Thanks @hugovk! Took the liberty of removing the old one myself. 👍

@nicoddemus nicoddemus merged commit c9eeafa into pytest-dev:master Jan 31, 2020
@hugovk hugovk deleted the update-favicon branch February 1, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants