Fix favicon for Chrome and Opera #6639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master
branch for bug fixes, documentation updates and trivial changes.features
branch for new features, improvements, and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
[n/a?] Create a new changelog file in the
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
.
.Add yourself to
AUTHORS
in alphabetical order.Old favicon
Right now, the favicon shows as a blank white box in Chrome and Opera. It's fine in Firefox.
The old
doc/en/img/pytest1favi.ico
from 2014 has two frames, one Pytest logo with a transparent background and one plain white box.Different browsers pick a different frame.
macOS Chrome 79
macOS Opera 65
macOS Firefox 72
Android Chrome 79
New favicon
Converted to PNG frames using ImageMagick, updated config to use the logo frame:
The
conf.py
comments say "This file should be a Windows icon file (.ico) being 16x16 or 32x32 pixels large", but PNG works fine in 2020.macOS Chrome 79
macOS Opera 65
macOS Firefox 72
TODO