Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: no_implicit_optional = False #6036

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 22, 2019

This allows for easier signatures.
@blueyed blueyed requested a review from bluetech October 22, 2019 19:52
@bluetech
Copy link
Member

I personally prefer it to be True, I find a signature like exprinfo: str = None to be inconsistent and surprising. But I don't feel strongly about it.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 22, 2019

Me neither, but I can see no benefit in the boilerplate overhead.
It is a nice shortcut IMHO, and mypy default to it IIRC.

blueyed added a commit to blueyed/pytest that referenced this pull request Oct 23, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Oct 23, 2019
@bluetech
Copy link
Member

@asottile
Copy link
Member

👎 strongly prefer being explicit here

@blueyed blueyed closed this Oct 23, 2019
@blueyed blueyed deleted the mypy-optional branch October 23, 2019 19:44
blueyed added a commit to blueyed/pytest that referenced this pull request Oct 23, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 2, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants