Merge master into features

[blueyed]

No description provided.

[nicoddemus]

Hmm linting fail for some reason

[blueyed]

No, docs:

docs create: /home/travis/build/pytest-dev/pytest/.tox/docs
docs installdeps: -r/home/travis/build/pytest-dev/pytest/doc/en/requirements.txt
docs develop-inst: /home/travis/build/pytest-dev/pytest
ERROR: invocation failed (exit code 1), logfile: /home/travis/build/pytest-dev/pytest/.tox/docs/log/docs-2.log
================================== log start ===================================
Obtaining file:///home/travis/build/pytest-dev/pytest
ERROR: Error installing 'file:///home/travis/build/pytest-dev/pytest': editable mode is not supported for pyproject.toml-style projects. This project is being processed as pyproject.toml-style because it has a pyproject.toml file with a "build-backend" key in the "build_system" value. See PEP 517 for the relevant specification.

Likely due to new pip release.

[nicoddemus]

Oh my. This is definitely a huge problem now.

[nicoddemus]

Just reading about this, with pip 19.1 develop installs do not work anymore, which of course is a problem for us (pypa/pip#6370).

There are a few workarounds:

• https://github.com/ansible/molecule/pull/2009/files
• jaraco/skeleton@123b0b2

but none of them are pretty.

Not sure how to proceed overall... this mean develop installs don't work at all anymore in the pytest tree.

[blueyed]

Not looked into this really now, but enabling isolated builds just because a pyproject.toml is present was a bad idea to begin with. IIRC the PEP was even clarified to not do this, but yeah.. an old comment from me: pypa/pip#5416 (comment)

[blueyed]

Here is a workaround/fix: pypa/pip#6433 (comment)

[nicoddemus]

Oh just now I saw this, and I already merged the other one (as master was broken otherwise) 😬

Anyway, the --no-use-pep517 does not work for us because we have a build_meta section in our pyproject.yml:

λ pip install -e . --no-use-pep517
Obtaining file:///C:/pytest
ERROR: Disabling PEP 517 processing is invalid: project specifies a build backend of setuptools.build_meta in pyproject.toml

(FTR I have tried that before falling back to comment the usedevelop sections in our tox.ini)

[codecov]

Codecov Report

Merging #5162 into features will increase coverage by 0.08%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##           features    #5162      +/-   ##
============================================
+ Coverage     96.03%   96.11%   +0.08%     
============================================
  Files           115      115              
  Lines         25948    25989      +41     
  Branches       2563     2563              
============================================
+ Hits          24918    24980      +62     
+ Misses          726      706      -20     
+ Partials        304      303       -1

Impacted Files	Coverage Δ
src/_pytest/reports.py	95.07% <ø> (ø)	⬆️
src/_pytest/config/__init__.py	94.43% <100%> (ø)	⬆️
testing/test_session.py	100% <100%> (ø)	⬆️
src/_pytest/_io/saferepr.py	80.43% <100%> (+1.36%)	⬆️
testing/test_config.py	99.49% <100%> (ø)	⬆️
src/_pytest/_code/code.py	95.5% <100%> (-0.02%)	⬇️
src/_pytest/nodes.py	95.58% <66.66%> (ø)	⬆️
src/_pytest/python.py	93.3% <66.66%> (ø)	⬆️
testing/code/test_excinfo.py	96.76% <95.65%> (-0.03%)	⬇️
testing/acceptance_test.py	98.04% <0%> (+0.39%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e57a7...7f519f8. Read the comment docs.

[blueyed]

Ok, pulled in here.