Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle exceptions in multiprocessing tasks #2028

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Properly handle exceptions in multiprocessing tasks #2028

merged 1 commit into from
Nov 3, 2016

Conversation

nicoddemus
Copy link
Member

Fix #1984

@nicoddemus
Copy link
Member Author

nicoddemus commented Oct 27, 2016 •
edited
Loading

Weird, Travis didn't start the build. In the requests page it says Build type disabled via repository setting (pull_request). Indeed, in settings the Build pushes and Build pull requests options are off. Did someone disable this by accident?

I will re-enable both and see what happens.

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Oct 27, 2016
@nicoddemus
Add a comment to trigger a new Travis build
154c624 
Travis was not configured to build pull-requests (see pytest-dev#2028)
@nicoddemus
Copy link
Member Author

Yep, back on. Weird.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 154c624 on nicoddemus:empty-tracebacks into * on pytest-dev:master*.

@nicoddemus
Copy link
Member Author

Anyone wants more time to take a look at this PR? Otherwise I plan to merge it in the next few days.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 92.796% when pulling 006a901 on nicoddemus:empty-tracebacks into 45b21fa on pytest-dev:master.

@nicoddemus nicoddemus merged commit f331e8f into pytest-dev:master Nov 3, 2016
@nicoddemus nicoddemus deleted the empty-tracebacks branch November 3, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@hpk42 hpk42 hpk42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @coveralls @hpk42 @RonnyPfannschmidt