Skip to content

[pre-commit.ci] pre-commit autoupdate #13387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 21, 2025

@nicoddemus
Copy link
Member

nicoddemus commented Apr 22, 2025

zizmor is failing with:

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/deploy.yml:34:7
   |
34 |       uses: hynek/build-and-inspect-python-package@v2.12.0
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

It wants us to update to hashes... however how does that affect dependabot updates?

@Pierre-Sassoulas
Copy link
Member

I think it still works and start using a hash instead (you don't have to change to a hash each time). I don't remember on what repo I saw that though. Doing this even if dependabot doesn't work anymore would make sense considering that an action owner can delete and recreate tags and completely change the pipelines behavior without any reviews, which is a lot of trust to give to anyone.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 319866b to d9f184b Compare April 28, 2025 20:03
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from b1a3352 to 41c03da Compare May 12, 2025 20:03
@Pierre-Sassoulas
Copy link
Member

Used the latest tag for softprops/action-gh-release@v2 and codecov/codecov-action@v5 which were implicitely the latest tag. We can expect to be spammed a lot more by dependabot, might be time to change the settings so it update less often.

@Pierre-Sassoulas Pierre-Sassoulas added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label May 12, 2025
@Pierre-Sassoulas Pierre-Sassoulas requested a review from webknjaz May 16, 2025 05:06
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 4342b75 to 363fb79 Compare May 19, 2025 20:08
pre-commit-ci bot and others added 2 commits May 20, 2025 10:21
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.5 → v0.11.10](astral-sh/ruff-pre-commit@v0.11.5...v0.11.10)
- [github.com/woodruffw/zizmor-pre-commit: v1.5.2 → v1.7.0](zizmorcore/zizmor-pre-commit@v1.5.2...v1.7.0)
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from 885f8ac to 76ee187 Compare May 20, 2025 08:21
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pierre-Sassoulas for tackling this!

@Pierre-Sassoulas Pierre-Sassoulas merged commit 85a76b8 into main May 22, 2025
28 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch May 22, 2025 13:41
Copy link

patchback bot commented May 22, 2025

Backport to 8.3.x: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 85a76b8 on top of patchback/backports/8.3.x/85a76b84296263eb6b13b59dd0641ff2f920dae2/pr-13387

Backporting merged PR #13387 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pytest-dev/pytest.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/8.3.x/85a76b84296263eb6b13b59dd0641ff2f920dae2/pr-13387 upstream/8.3.x
  4. Now, cherry-pick PR [pre-commit.ci] pre-commit autoupdate #13387 contents into that branch:
    $ git cherry-pick -x 85a76b84296263eb6b13b59dd0641ff2f920dae2
    If it'll yell at you with something like fatal: Commit 85a76b84296263eb6b13b59dd0641ff2f920dae2 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 85a76b84296263eb6b13b59dd0641ff2f920dae2
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR [pre-commit.ci] pre-commit autoupdate #13387 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/8.3.x/85a76b84296263eb6b13b59dd0641ff2f920dae2/pr-13387
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants