Fix scandir() crash by returning [] when directory is not found (#13083) #13086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
reviewed
Dec 26, 2024
nicoddemus
reviewed
Dec 26, 2024
nicoddemus
reviewed
Dec 26, 2024
Tusenka
approved these changes
Dec 27, 2024
nicoddemus
approved these changes
Jan 6, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @delta87 for the contribution!
nicoddemus
force-pushed
the
bugFix/scandir-empty-dir
branch
from
bd13b60 to
835d81b
Compare
Member
|
Hmmm the failure is unrelated, will try to investigate this later. |
Member
Once the fix is in and this PR gets rebased, hopefully things are all green again! |
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
for more information, see https://pre-commit.ci
nicoddemus
force-pushed
the
bugFix/scandir-empty-dir
branch
from
835d81b to
476e31a
Compare
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13117 🤖 @patchback |
nicoddemus
pushed a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #13083 by modifying the scandir function to handle the case where a non-existent directory is provided. Previously, the function did not return a result for such cases, potentially leading to unhandled errors. Now, if the directory does not exist, the function will return an empty list instead.
Changes made:
Updated scandir to catch FileNotFoundError and return an empty list if the directory does not exist.
Updated the function docstring to reflect the new behavior.
Testing:
Also two tests were added.
Closes #13083