Separate 2.9.0 CHANGELOG into sections #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
changelog-sections
branch
from
37da841
to
6b25fb4
Compare
RonnyPfannschmidt
added a commit
that referenced
this pull request
Dec 26, 2015
Separate 2.9.0 CHANGELOG into sections
|
👍 |
| * New `-rp` and `-rP` reporting options give the summary and full output | ||
| of passing tests, respectively. Thanks to David Vierra for the PR. | ||
|
|
||
| Bug Fixes/Adjustments |
There was a problem hiding this comment.
Hmm in retrospect, I think this should just be "Bug Fixes", and the #1226 mention in this section should be moved to "Changes". As it stands now, "Adjustments" and "Changes" is ambiguous (after all, it seems an "adjustment" is just a "small change", which is not good IMO), and even an internal refactoring is a change after all (as much as we would like for them to have no impact at all, it might just happen some corner case creeps up).
But I will fix this in a later commit, unless you disagree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra Changes section as suggested by @RonnyPfannschmidt.
Also replace section titles from
---to===, and changed sections to then use---. With sections, this looks better IMO.Fix #1275