Improve approx scalar repr method for better readability by fazeelghafoor · Pull Request #12665 · pytest-dev/pytest

fazeelghafoor · 2024-07-29T01:27:11Z

Closes #6985

Include documentation when adding new features.
Include new tests or update existing tests when applicable.
Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.
Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number).
Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst.
Add yourself to AUTHORS in alphabetical order.

…for common ranges

fazeelghafoor · 2024-07-29T01:30:44Z

@Zac-HD please review and let me know if there are any changes required.

Pierre-Sassoulas

Thank you for the pull request !

Did you see this comment in the original issue : #6985 (comment) ?

fazeelghafoor · 2024-07-29T20:05:42Z

@Pierre-Sassoulas thank you for the feedback. I had missed the comment so I have added the 'n' format specifier as well. Please let me know what else needs to changed

Pierre-Sassoulas

Some tests results to upgrade otherwise LGTM

fazeelghafoor · 2024-07-30T00:12:09Z

added test cases as well

Pierre-Sassoulas

The pipeline is still failing, some existing tests need to be upgraded too.

fazeelghafoor · 2024-07-31T00:13:01Z

@Pierre-Sassoulas updated existing tests

Pierre-Sassoulas

Great, do you mind adding a changelog too, please ?

Pierre-Sassoulas · 2024-07-31T04:16:02Z

src/_pytest/runner.py

        sys.last_value = e
        if sys.version_info >= (3, 12, 0):
-            sys.last_exc = e
+            sys.last_exc = e  # type: ignore[attr-defined]


Seems like this type ignores are unused in the CI (see pre-commit job).

nicoddemus

LGTM, left some minor comments.

changelog/6985.improvement.rst

src/_pytest/python_api.py

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>

for more information, see https://pre-commit.ci

fazeelghafoor · 2024-07-31T19:20:04Z

@nicoddemus thanks for the suggestions. can you let me know what could be causing the readthedocs check to fail. I don't understand the error

The-Compiler · 2024-07-31T19:35:49Z

Looks like an issue unrelated to your PR: sphinx-contrib/sphinxcontrib-towncrier#92

nicoddemus · 2024-07-31T19:37:37Z

can you let me know what could be causing the readthedocs check to fail. I don't understand the error

It might be some regression on towncrier/sphinx extension, I noticed there was a new release towncrier release 5 hrs ago:

https://pypi.org/project/towncrier/#history

Don't worry, seems unrelated to your changes.

The-Compiler

Looking great!

nicoddemus · 2024-07-31T19:53:42Z

Opened #12675 to fix the readthedocs/towncrier issue, we can update with main once that lands.

changelog/6985.improvement.rst

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

changelog/6985.improvement.rst

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

Pierre-Sassoulas · 2024-08-01T17:55:10Z

Great !

fazeelghafoor added 2 commits July 29, 2024 06:25

resolve mypy error: Module has no attribute last_exc [attr-defined]

51ddeaf

adjust __repr__ in ApproxScalar to format tolerances in decimal form …

82580cb

…for common ranges

fazeelghafoor changed the title ~~resolve mypy error: Module has no attribute last_exc [attr-defined]~~ Improve readability of approx method scalar __repre__ method for better readability Jul 29, 2024

fazeelghafoor changed the title ~~Improve readability of approx method scalar __repre__ method for better readability~~ Improve readability of approx scalar repr method for better readability Jul 29, 2024

fazeelghafoor marked this pull request as ready for review July 29, 2024 01:29

fazeelghafoor changed the title ~~Improve readability of approx scalar repr method for better readability~~ Improve approx scalar repr method for better readability Jul 29, 2024

Pierre-Sassoulas reviewed Jul 29, 2024

View reviewed changes

add 'n' format specifier for readable tolerance numbers

7c1a6df

Pierre-Sassoulas requested changes Jul 29, 2024

View reviewed changes

add tests for improved tolerance approx repr output

738592d

fazeelghafoor requested a review from Pierre-Sassoulas July 29, 2024 22:30

Pierre-Sassoulas requested changes Jul 30, 2024

View reviewed changes

update existing tests for improved approx scalar repr output

c71e990

fazeelghafoor requested a review from Pierre-Sassoulas July 31, 2024 00:12

Pierre-Sassoulas requested changes Jul 31, 2024

View reviewed changes

fazeelghafoor added 3 commits July 31, 2024 16:35

add changelog

228b356

remove type ignores

42e80e7

add changelog fragment

549b6c7

psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jul 31, 2024

nicoddemus approved these changes Jul 31, 2024

View reviewed changes

changelog/6985.improvement.rst Outdated Show resolved Hide resolved

changelog/6985.improvement.rst Outdated Show resolved Hide resolved

src/_pytest/python_api.py Outdated Show resolved Hide resolved

fazeelghafoor and others added 4 commits July 31, 2024 23:44

Update changelog/6985.improvement.rst

d17145c

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>

Update changelog/6985.improvement.rst

bc1af0b

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>

Update src/_pytest/python_api.py

90402fe

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>

[pre-commit.ci] auto fixes from pre-commit.com hooks

784a953

for more information, see https://pre-commit.ci

fazeelghafoor requested review from nicoddemus July 31, 2024 19:18

Merge branch 'main' into fix/improve-approx-repr

daeaa01

The-Compiler approved these changes Jul 31, 2024

View reviewed changes

Merge branch 'main' into fix/improve-approx-repr

afb2f63

nicoddemus requested a review from Pierre-Sassoulas August 1, 2024 10:29

Pierre-Sassoulas reviewed Aug 1, 2024

View reviewed changes

changelog/6985.improvement.rst Outdated Show resolved Hide resolved

Update changelog/6985.improvement.rst

f104f71

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

Pierre-Sassoulas reviewed Aug 1, 2024

View reviewed changes

changelog/6985.improvement.rst Outdated Show resolved Hide resolved

changelog/6985.improvement.rst Outdated Show resolved Hide resolved

fazeelghafoor and others added 2 commits August 1, 2024 22:07

Update changelog/6985.improvement.rst

915d4c7

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

Update changelog/6985.improvement.rst

e91228f

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

Pierre-Sassoulas approved these changes Aug 1, 2024

View reviewed changes

nicoddemus approved these changes Aug 1, 2024

View reviewed changes

nicoddemus merged commit 5a01583 into pytest-dev:main Aug 1, 2024

Uh oh!

Comments

Conversation

fazeelghafoor commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fazeelghafoor commented Jul 29, 2024

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

fazeelghafoor commented Jul 29, 2024

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

fazeelghafoor commented Jul 30, 2024

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

fazeelghafoor commented Jul 31, 2024

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fazeelghafoor commented Jul 31, 2024

Uh oh!

The-Compiler commented Jul 31, 2024

Uh oh!

nicoddemus commented Jul 31, 2024

Uh oh!

The-Compiler left a comment

Choose a reason for hiding this comment

Uh oh!

nicoddemus commented Jul 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pierre-Sassoulas commented Aug 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fazeelghafoor commented Jul 29, 2024 •

edited

Loading